search

BlueMap-Minecraft / BlueMap

A Minecraft mapping tool that creates 3D models of your Minecraft worlds and displays them in a web viewer.
https://bluecolo.red/bluemap
MIT License
1.92k stars 131 forks source link

Docker: "latest" tag should always point at the highest release number #550

Open chaosfreak93 opened 5 months ago

chaosfreak93 commented 5 months ago

Hello,

Could it be possible to not push "Snapshot" versions to the "latest" Docker Tag? In my opinion "latest" is normally meant to be the latest stable Version of a Product/Image. "Snapshots" could be seperated into a own tag like "snapshot", "dev" or "nigthly".

Chicken commented 5 months ago

Sorry this is on me, I have arbitrarily decided that latest is the actual latest. You should never actually use the tag, nor should you actually any other tag other than direct version pinning (eg. v3.21) because every BlueMap release can introduce changes which may require human intervention. I have been thinking and maybe we will remove the tag altogether.

TBlueF commented 5 months ago

Out of interest: can you find me some meaningful docs that say that "latest" should be a stable version? ^^ To me, latest is latest. And you shouldn't use it if you don't want things to break :)

BlueMap very often needs some (usually small) manual steps you need to do when upgrading to a never version, so i can't recommend just pulling the latest release anyways.

An argument can be made that the latest tag should always point at the highest release number instead of pointing at the last version that was released, but that still would be a release with "snapshot" status right now. Or like @Chicken suggested maybe we should just remove the tag ^^

chaosfreak93 commented 5 months ago

Out of interest: can you find me some meaningful docs that say that "latest" should be a stable version? ^^ To me, latest is latest. And you shouldn't use it if you don't want things to break :)

BlueMap very often needs some (usually small) manual steps you need to do when upgrading to a never version, so i can't recommend just pulling the latest release anyways.

An argument can be made that the latest tag should always point at the highest release number instead of pointing at the last version that was released, but that still would be a release with "snapshot" status right now. Or like @Chicken suggested maybe we should just remove the tag ^^

I changed my sentence but i also would say it could be better to just remove the "latest" tag.

drewburr commented 4 months ago

An argument can be made that the latest tag should always point at the highest release number instead of pointing at the last version that was released, but that still would be a release with "snapshot" status right now. Or like @Chicken suggested maybe we should just remove the tag ^^

This is, IMO, the correct use of :latest. It should not be used if you are hoping for a stable and reliable experience. Assuming semver is used and the standard is followed when creating releases, there are far better options for floating versions. As for the request to remove it, it shouldn't need to be removed, just don't use it unless there's a good reason to do so

Edit: Should probably use Semver before supporting a latest tag. Regardless, targeting latest for use is poor practice

Chicken commented 4 months ago

Fyi BlueMap does not use semver.