search

BluePandaLi / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

Mp4tags doesn't correctly add the iTunes short description when used on an untagged m4v file #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Encode movie using Handbrake 0.9.3 as M4V - AppleTV profile
2. Added short description tag using mp4tags (-m option)
# ./mp4tags -m "My short description..." /mnt/hgfs/Vserv/LayerCake-2.m4v 
./mp4info /mnt/hgfs/Vserv/LayerCake-2.m4v 
/home/rsandru/mp4v2/build/.libs/lt-mp4info version 2.0-r248
/mnt/hgfs/Vserv/LayerCake-2.m4v:
Track   Type    Info
1   video   H264 Main@3, 381.760 secs, 935 kbps, 720x432 @ 25.000000 fps
2   audio   MPEG-4 AAC LC, 381.653 secs, 160 kbps, 48000 Hz
3   audio   ac-3, 381.632 secs, 448 kbps, 48000 Hz
4   text
 Encoded with: HandBrake 0.9.3 2008112300
 Short Description: My short description...

3. Added file to iTunes, description field is empty. When played in QuickTime, 
the description 
shows a weird string. (See attachments)

4. Edited the field in iTunes and saved it, mp4info shows it correctly:
./mp4info /mnt/hgfs/Vserv/LayerCake-2.m4v 
/home/rsandru/mp4v2/build/.libs/lt-mp4info version 2.0-r248
/mnt/hgfs/Vserv/LayerCake-2.m4v:
Track   Type    Info
1   video   H264 Main@3, 381.760 secs, 935 kbps, 720x432 @ 25.000000 fps
2   audio   MPEG-4 AAC LC, 381.653 secs, 160 kbps, 48000 Hz
3   audio   ac-3, 381.632 secs, 448 kbps, 48000 Hz
4   text
 Encoded with: HandBrake 0.9.3 2008112300
 Short Description: Short desc added in iTunes....
5) Edited again using mp4tags and the changes are now reflected in iTunes...

What is the expected output? What do you see instead?
iTunes doesn't show the short description field when the file is tagged using 
mp4tags. If the field 
is edited first in iTunes, subsequent updates with mp4tags work just fine.

What version of the product are you using? On what operating system?
Checked out latest version from SVN.
configure:
  -->
  --> Configuring MP4v2 2.0-r248
  -->

Running on Ubuntu 8.04.1
Linux vserv 2.6.24-19-server #1 SMP Wed Aug 20 23:54:28 UTC 2008 i686 GNU/Linux

Original issue reported on code.google.com by robert.s...@gmail.com on 21 Jan 2009 at 11:06

Attachments:

GoogleCodeExporter commented 9 years ago 
Was able to reproduce the error.

Apparently it happens for all strings, haven't tested other data types.

This is how a dump of the mp4tags output looks like:
     type desc (moov.udta.meta.ilst.desc)
      type data (moov.udta.meta.ilst.desc.data)
       typeReserved = 0 (0x0000)
       typeSetIdentifier = 0 (0x00)
       typeCode = UNDEFINED(255) (0xff)
       locale = 0 (0x00000000)
       metadata = <9 bytes>  73 6f 6d 65 20 64 65 73 63  |some desc|

And this is how iTunes writes it:

     type desc (moov.udta.meta.ilst.desc)
      type data (moov.udta.meta.ilst.desc.data)
       typeReserved = 0 (0x0000)
       typeSetIdentifier = 0 (0x00)
       typeCode = UTF-8 (0x01)
       locale = 0 (0x00000000)
       metadata = <9 bytes>  73 6f 6d 65 20 64 65 73 63  |some desc|

So we write the wrong Type Code.

Original comment by pentiumforever@gmail.com on 26 Jan 2009 at 4:33

GoogleCodeExporter commented 9 years ago 
I misspoke. We do write some string tags correctly. So far I've only found cprt 
and desc that aren't written 
correctly.

Original comment by pentiumforever@gmail.com on 26 Jan 2009 at 4:39

GoogleCodeExporter commented 9 years ago 
Fixed in r250.

Original comment by pentiumforever@gmail.com on 27 Jan 2009 at 6:11