Neighbor Orientation Comparison Filter giving incorrect results

BlueQuartzSoftware / DREAM3D

Data Analysis program and framework for materials science data analytics, based on the managing framework SIMPL framework.

http://dream3d.bluequartz.net

Other

163 stars 76 forks source link

Neighbor Orientation Comparison Filter giving incorrect results #242

Closed imikejackson closed 9 years ago

imikejackson commented 9 years ago

Dear developers, I am not sure of correct implementation of the Neighbor Orientation Comparison (Bad data) filter. If I look to the source file BadDataNeighborOrientationCheck.cpp, line 305, there is quats[neighbor] copied to q1 but one would expect it to be copied to q2. The q1 is used for storing quats[i] immediately above. I think the current implementation causes incorrect functionality of this filter.

Reported by Ondrej Sedivy DREAM3D Versions 4 & 5.

imikejackson commented 9 years ago

This code is correct on m_Develop and master branch (which are the branches used for version 4.2.x) and has been corrected on the 'attributeMatrix' branch which is what is used for the version 5.x builds.