search

BlueQuartzSoftware / DREAM3D

Data Analysis program and framework for materials science data analytics, based on the managing framework SIMPL framework.
http://dream3d.bluequartz.net
Other
167 stars 77 forks source link

StatsGeneratorODFWidget attempts to use a class from SVWidgetsLib that is not exported #673

Closed sdonegan closed 7 years ago

sdonegan commented 7 years ago

Specifically, StatsGeneratorODFWidget attempts to instantiate a ProgressDialog from SVWidgetsLib, but ProgressDialog does not currently have the correct export macro (SVWidgetsLib_EXPORT); this causes a link error on Windows. Commit dd62d39 from the SIMPL repo seems to indicate that the ProgressDialog may have some unwanted interactions, so a fix would be to just comment out the usage of ProgressDialog in StatsGeneratorODFWidget, which occurs in the calculateODF() function (bug is here on DREAM3D for that reason).

Another fix is to add the export macro to ProgressDialog over in the SIMPL repo.

imikejackson commented 7 years ago

Fixed by adding the export macro in the source code.