BlueQuartzSoftware / EbsdLib

C++ Library that can read EBSD Files from OEMs and perform basic EBSD processing such as orientation conversion
BSD 3-Clause "New" or "Revised" License
5 stars 11 forks source link

CtfReader doesn't parse space group and comment of a phase when Internal1 and Internal2 are empty #16

Open LudovicDrtt opened 1 year ago

LudovicDrtt commented 1 year ago

I'm trying to read a ctf file where the phase is defined as follow

Phases  1
2.866;2.866;2.866   90.000;90.000;90.000    bcc 11  229         Phase comment

with the fields Internal1 and Internal2 empty.

However, when I load the file, the parser doesn't read the space group and the comment and it defined the following phase (print with the method CtfPhase::printSelf) :

LatticeConstants 2.866, 2.866, 2.866 90, 90, 90
PhaseName bcc
LaueGroup 11
SpaceGroup 0
Internal1 
Internal2 
Comment

But if I fill the Internal1 and Internal2 fields with a space character, the phase is correctly read and CtfPhase::printSelf give :

LatticeConstants 2.866, 2.866, 2.866 90, 90, 90
PhaseName bcc
LaueGroup 11
SpaceGroup 229
Internal1  
Internal2  
Comment Phase comment

I'm using EbsdLib 1.0.22, download from github and compile by myself.

imikejackson commented 6 months ago

@LudoBike Sorry for not seeing this earlier. I need to get this repo on my slack notifications. Can I get the CTF file in question for testing? We actively use EbsdLib for DREAM.3D and it would be nice to ensure things are working properly

LudovicDrtt commented 4 months ago

@imikejackson I'm sorry I don't have access to the CTF file anymore, but I think that you can replicate the issue by replacing the phase description in any CTF file with the one I provided in my first post (first code block).