BlueQuartzSoftware / simplnx

The backend algorithms and framework associated with DREAM3DNX, a data analysis program for materials science data analytics
http://www.dream3d.io/
Other
7 stars 9 forks source link

ENH: xtensor stores #1001

Closed mmarineBlueQuartz closed 3 months ago

mmarineBlueQuartz commented 3 months ago

Add xtensor-backed data stores to SIMPL NX.

Added data stores for:

Updated DataArray's AbstractDataStore to use xt::xarray

Add vcpkg dependencies for xtensor. Include xtensor libraries.

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file simplnx/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file simplnx/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

Code Cleanup

imikejackson commented 3 months ago

@mmarineBlueQuartz Are we adding back in support for GHCFileSystem? All of our compilers that we support no longer need that package. Or is that a dependency for XTensor?

mmarineBlueQuartz commented 3 months ago

@mmarineBlueQuartz Are we adding back in support for GHCFileSystem? All of our compilers that we support no longer need that package. Or is that a dependency for XTensor?

XTensor. One of the includes was causing errors when it wasn't found.

imikejackson commented 3 months ago

Closed because there is a new branch to work from.