BlueQuartzSoftware / simplnx

The backend algorithms and framework associated with DREAM3DNX, a data analysis program for materials science data analytics
http://www.dream3d.io/
Other
7 stars 9 forks source link

PYTHON: Add helper methods to be able to easily create all the geometries. #981

Closed joeykleingers closed 3 months ago

joeykleingers commented 3 months ago

Adds the following helper methods to be able to easily create all the geometries:

nx.CreateGeometry.create_image_geometry nx.CreateGeometry.create_rect_grid_geometry nx.CreateGeometry.create_vertex_geometry nx.CreateGeometry.create_edge_geometry nx.CreateGeometry.create_triangle_geometry nx.CreateGeometry.create_quad_geometry nx.CreateGeometry.create_tetrahedral_geometry nx.CreateGeometry.create_hexahedral_geometry

Also adds parameter names to the ChoicesParameter binding.

imikejackson commented 3 months ago

We talked about the API returning a Result<> object.

joeykleingers commented 3 months ago

We talked about the API returning a Result<> object.

They all return Result objects.

JDuffeyBQ commented 3 months ago

Were we going to merge the various ArrayHandlingType enums/values for these bindings?

imikejackson commented 3 months ago

@JDuffeyBQ Those changes should be on https://github.com/BlueQuartzSoftware/simplnx/pull/983/

JDuffeyBQ commented 3 months ago

Ah then that enum should be bound using py::enum_ here.

joeykleingers commented 3 months ago

This is ready for review again.