ENH/BUG : Update node based geometry find element family of functions

jmarquisbq commented 2 months ago

properly checks for nullptrs
allow user to either leave array as is or recalculate it if the array already exists

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file simplnx/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file simplnx/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

[ ] 1 Unit test to test output from the filter against known exemplar set of data
[ ] 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

[ ] No commented out code (rare exceptions to this is allowed..)
[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added example pipelines that use the filter
[ ] Classes and methods are properly documented

imikejackson commented 2 months ago

Waiting on https://github.com/BlueQuartzSoftware/simplnx/pull/998

imikejackson commented 2 months ago

https://github.com/BlueQuartzSoftware/simplnx/pull/984 needs this PR

BlueQuartzSoftware / simplnx