BlueRaja / High-Speed-Priority-Queue-for-C-Sharp

A C# priority queue optimized for pathfinding applications
MIT License
1.15k stars 169 forks source link

Add strong name to this NuGet #53

Closed maxkoshevoi closed 3 years ago

maxkoshevoi commented 3 years ago

Could you please add string name to this assembly? I cannot reference it in my project that is strongly named.

First I get this warning on compile time:

CS8002  Referenced assembly 'Priority Queue, Version=4.2.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

And than this error on runtime:

System.IO.FileLoadException: Could not load file or assembly 'Priority Queue, Version=4.2.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)
toeb commented 3 years ago

I am having the same issue.
I will be trying this https://stackoverflow.com/questions/1220519/how-to-sign-a-net-assembly-dll-file-with-a-strong-name in the mean time

BlueRaja commented 3 years ago

The assemblies are now Strong Name signed in 5.1.0.

I've included the private keys in the repo, as recommended by Microsoft. This comes as a surprise to many people, but Strong Names are not a security feature.