search

BlueStaggo / moderner-beta

MIT License
16 stars 1 forks source link

Can't get beta 1.7.3 far lands to generate above y=128 #20

Open xp2-882030kgz010602 opened 3 weeks ago

xp2-882030kgz010602 commented 3 weeks ago

I have tried changing the "height" tag (line 15) from 128 to 256 in both beta.json and modern_beta.json, but I cannot get the far lands to generate above y=128. I know that it should be possible, since those same far lands generate below y=0 into deepslate, while the "real" beta 1.7.3 couldn't have done this at all.

xp2-882030kgz010602 commented 3 weeks ago

Update: I've found that there's a worldHeight parameter in ModernBetaChunkGenerator, but I can't figure out how that gets initialized since it seems to go back into MC code.

xp2-882030kgz010602 commented 3 weeks ago

I was also able to "fix" this by editing line 74 in ChunkProviderNoise.java to hardcode in 384 instead of reading from shapeConfig.

BlueStaggo commented 1 week ago

Yeah, I should make the maximum height configurable in the chunk provider instead of being dependent on the noise config.