search

BlueTeaLondon / heroku-buildpack-libreoffice-for-heroku-18

Other
17 stars 31 forks source link

Use versionless url for AppImage #1

Closed vesatoivonen closed 5 years ago

vesatoivonen commented 5 years ago

Old images seem to go offline once newer versions are released. Let's hope this url doesn't break that often.

vesatoivonen commented 5 years ago

I was going to fix that later too by using INSTALLED_VERSION=$(ls $ACTUAL_INSTALL_PATH/opt) instead, so that the used version would be defined only with a single variable. Eventually i'd like to see the version definition to be moved to a configuration file, so that the users could pin their version if they wanted to, with the risk of breaking more often of course.

geomic commented 5 years ago

That sounds great!

geomic commented 5 years ago

Let me know if you would prefer me to merge in the meantime, so you can use the repository.

vesatoivonen commented 5 years ago

Yeah you can merge this one and i'll submit another pr for main version fix today.

geomic commented 5 years ago

Sure. Another thing to consider is the slug limit on heroku, in case with the new version the script attempts (which it might.00..) to download a new LibreOffice version alongside the current, rather than replace it.

When I have some time I'll check if my check runs on the ACTUAL_INSTALL_PATH. That would be ideal, with the script removing any older versions for any new version defined in the config.