BlueTeaLondon / heroku-buildpack-libreoffice-for-heroku-18

Other
17 stars 31 forks source link

Unofficial appimages expires from time to time #24

Open krzykamil opened 11 months ago

krzykamil commented 11 months ago

I guess this is a repeat of https://github.com/BlueTeaLondon/heroku-buildpack-libreoffice-for-heroku-18/issues/8 soluzionopen seems to have an expired certificate. Until it gets refreshed, the buildpack is broken. According to the README, the way to prevent that from happening is download the appimage from https://www.libreoffice.org/download/appimage/ and hosting it by my own somewhere, and then create LibreOfficeAppImage file in my root folder of the project to point to the self-hosted URL? What is the reason for his buildpack to be using unofficial appimages?

vesatoivonen commented 11 months ago

Yeah. Just use LibreOfficeAppImage and you're good to go. Soluzionopen was once an "official" provider for appimages and was thus selected for this buildpack.

geomic commented 11 months ago

Really appreciate the community's engagement with this, and your efforts @vesatoivonen! Unfortunately although I had plans to modernise/bring up to speed, work got the best of me...

krzykamil commented 11 months ago

Alright, thanks for the clarification. Just to confirm I did create the LibreOfficeAppImage and put in https://appimages.libreitalia.org/LibreOffice-still.standard-x86_64.AppImage. Deploy that was crashing before cause of it, went through.

Would you maybe accept a PR that changes the current DOWNLOAD= set in https://github.com/BlueTeaLondon/heroku-buildpack-libreoffice-for-heroku-18/blob/master/bin/compile? Seems like a simple enough change? Not sure if anything else would need to get changed.

geomic commented 11 months ago

LibreItalia appears to be, presently, a valid mirror. Can you confirm if it works for you with the 'latest' AppImage above though? Conscious it's been a while, and compatibility with heroku-18 might require other linux packages for modern versions of Libreoffice..

krzykamil commented 11 months ago

Note that we also have an Aptfile in the app. Not sure if that is relevant, but better to mention it than don't. Another thing maybe worth mentioning is that this is all done with dokku, I am not using heroku, just the buildpacks for dokku. https://dokku.com/docs/deployment/builders/herokuish-buildpacks/ The entries in Aptfile that could be related:

libsm6
libice6
libxinerama1
libdbus-glib-1-2
libharfbuzz0b
libharfbuzz-icu0
libx11-xcb1
libxcb1

Anyway I've replaced the AppImage on our test environment with the latest one and tested it. The things we use LibreOffice for are still fine, no problems noted.

I will still be using the stable release instead of latest for production stability reasons, but yea, the latest image seems fine.

jesnaultatixnet commented 7 months ago

Hello, I've submitted a pull request for the modification of the LibreOffice image. Could you take a look? Thanks in advance.