BlueWallet / BlueWallet

Bitcoin wallet for iOS & Android. Built with React Native
https://bluewallet.io
MIT License
2.49k stars 768 forks source link

Bip47 & Reusable Payment Codes version 3 & 4 #2883

Open yoshimo opened 3 years ago

yoshimo commented 3 years ago

Since we are getting closer to TOR Support, it would be great to get additional support for privacy enhancing features. Colloquial, PayNyms. These are specified in Bip47 as implemented by Samourai and enhanced in https://github.com/OpenBitcoinPrivacyProject/rfc/blob/master/obpp-05.mediawiki Having more wallets support this venmo style method for sending money to your friends, would benefit the ecosystem in general.

yoshimo commented 2 years ago

150k Sats for an implementation

yoshimo commented 2 years ago

@Overtorment could you add the bounty-label?

ghost commented 2 years ago

Count me in for another 850k sats

acantril commented 2 years ago

Count me in for 1 million sats

dav1dpgit commented 2 years ago

In for 100k sats

ghost commented 2 years ago

This could be huge. In for 100k sats.

coinsurenz commented 2 years ago

1 million sats to this worthy cause

modl21 commented 2 years ago

count me in for a million sats

RequestPrivacy commented 2 years ago

Not a fan of iOS but it will help Bitcoin so 25,000 sats from me.


Total bounty: 4.250.000 sats

ghost commented 2 years ago

Another 250k from @Jorj_X_McKie on Twitter

https://twitter.com/Jorj_X_McKie/status/1494366711709159430?s=20&t=vKlwZaVyPHEg5kiKgPg4Xg


Total bounty: 4,500,000 SATs

ghost commented 2 years ago

Member of Citadel Dispatch matrix group pledged another 1 million sats

Screen Shot 2022-02-17 at 10 41 55

Total bounty: 5,500,000 SATs

Ziya-Sadr commented 2 years ago

count me in for 100k sats

apemithrandir commented 2 years ago

500k Sats

btcuserguide commented 2 years ago

i'm in for 1,000,000

BTclaudia commented 2 years ago

I'm down for 500k SATs

ion497 commented 2 years ago

Count me in for 200k sats

ghost commented 2 years ago

Another 300k from @Does_not_mattr on Twitter

https://twitter.com/Does_not_mattr/status/1495321573208858625


Total bounty: 8,100,000 SATs

jamesgmorgan commented 2 years ago

I pledge 125K sats donated over paynym upon completion.

ghost commented 2 years ago

Another 100k from Meister Eder on Twitter

https://twitter.com/Meister_Ancap/status/1495473258258382850


Total bounty: 8,525,000 SATs

diegoperezcham commented 2 years ago

Count me in for 475K sats

TheGuySwann commented 2 years ago

Put me down for 1,000,000 sats to make it an even 10 👍🏻

alaznem commented 2 years ago

count me in for 40k sat

FreddyPPFinklemeyerIII commented 2 years ago

I’m in for 1,000,000 million sats

ghost commented 2 years ago

Another 500k from Isaiah Douglass, MBA, CFP on Twitter

https://twitter.com/IDFinancial/status/1495503166133215232


Total bounty: 11,500,040 SATs

ghost commented 2 years ago

Another 300k from AmBird on Twitter

https://twitter.com/TurboSloth1869/status/1495554918656233472


Total bounty: 11,800,040 SATs

ghost commented 2 years ago

Another 100k from Honk Honk MetaMick on Twitter

https://twitter.com/metamick14/status/1495850492978733062


Total bounty: 11,900,040 SATs

pointbiz commented 2 years ago

"bc1qq5y96828txk8lruha27l8gpkhtfc55u3f87s5q" "JxylYiEmkCdFTxHd+u2MBfvZpH66oUhw8v+Dm5y7PMh4bGDOTYQZnxywHTYjGY/MjVJKLpzUVq0NAYxwtcojRCs=" "I, pointbiz aka BTCCuracao, pledge 19,500,000 sat bounty for Bluewallet github issue 2883. BIP47 v3 v4 reusable payment codes. The bounty to be paid after the first successful release of this feature as I deem it."

karozagorus commented 2 years ago

There are very serious privacy concerns and traceability related to identifiers mentioned by this highly respected developer here: https://twitter.com/EricSirion/status/1494436823036272640

ncoelho commented 2 years ago

https://twitter.com/EricSirion/status/1494436823036272640

That's not how it works. Eric even says he realizes that later on the thread...

karozagorus commented 2 years ago

https://twitter.com/EricSirion/status/1494436823036272640

That's not how it works. Eric even says he realizes that later on the thread...

He never stated that apparently.

ncoelho commented 2 years ago

Not sure why you are trying to fud bip47. Which is 7 year old bip with a lot of review.

Eric says he doesn't understand it. Which is natural if you didn't look deep enough.

https://twitter.com/ericsirion/status/1494633806069960707?s=21

karozagorus commented 2 years ago

Not sure why you are trying to fud bip47. Which is 7 year old bip with a lot of review.

Eric says he doesn't understand it. Which is natural if you didn't look deep enough.

https://twitter.com/ericsirion/status/1494633806069960707?s=21

I'm just worried that Bluewallet's privacy might get compromised if this is allowed into it, especially since people are giving you monetary incentives now to add features.

acantril commented 2 years ago

That whole thread is embarrassing - imagine someone saying 'why bother with bitcoin or lightning, or i don't see the point in BTC/LN'

karozagorus commented 2 years ago

That whole thread is embarrassing - imagine someone saying 'why bother with bitcoin or lightning, or i don't see the point in BTC/LN'

Agreed, its a cringe anti-LN stance they are doing.

acantril commented 2 years ago

I'm just worried that Bluewallet's privacy might get compromised if this is allowed into it, especially since people are giving you monetary incentives now to add features.

Privacy compromised by a privacy feature? and privacy of a product which has no privacy as it uses the BTC, by default 0 privacy.

acantril commented 2 years ago

Actually no, embarrassing isn't strong enough .. but i don't want to use the word i'm really thinking of.

ncoelho commented 2 years ago

Not sure why you are trying to fud bip47. Which is 7 year old bip with a lot of review.

Eric says he doesn't understand it. Which is natural if you didn't look deep enough.

https://twitter.com/ericsirion/status/1494633806069960707?s=21

I'm just worried that Bluewallet's privacy might get compromised if this is allowed into it, especially since people are giving you monetary incentives now to add features.

Bip47 is onchain, doesn't use 3rd parties or servers. So it is not possible to compromise bluewallet's privacy.

Users are putting a bounty, other users forked and are trying to get the bounty. There's zero monetary incentives to bluewallet.

karozagorus commented 2 years ago

Not sure why you are trying to fud bip47. Which is 7 year old bip with a lot of review.

Eric says he doesn't understand it. Which is natural if you didn't look deep enough.

https://twitter.com/ericsirion/status/1494633806069960707?s=21

I'm just worried that Bluewallet's privacy might get compromised if this is allowed into it, especially since people are giving you monetary incentives now to add features.

Bip47 is onchain, doesn't use 3rd parties or servers. So it is not possible to compromise bluewallet's privacy.

Users are putting a bounty, other users forked and are trying to get the bounty. There's zero monetary incentives to bluewallet.

But doesn't the channel establishment require you to pay a fee for scamourai wallet?

ncoelho commented 2 years ago

But doesn't the channel establishment require you to pay a fee for scamourai wallet?

No. As I said this is bitcoin onchain, there's no samourai or servers involved.

Nothing like learning something before commenting about it.

karozagorus commented 2 years ago

But doesn't the channel establishment require you to pay a fee for scamourai wallet?

No. As I said this is bitcoin onchain, there's no samourai or servers involved.

Nothing like learning something before commenting about it.

Well, since nobody verified this to be not leaking something I still don't trust it.

ncoelho commented 2 years ago

Well, since nobody verified this to be not leaking something I still don't trust it.

What do you mean? It literally is a bip (47) on bitcoin repository reviewed by some of the best cryptographers in the world.

You may not like samourai wallet implementation. But this has literally nothing to do with it.

karozagorus commented 2 years ago

Well, since nobody verified this to be not leaking something I still don't trust it.

What do you mean? It literally is a bip (47) on bitcoin repository reviewed by some of the best cryptographers in the world.

You may not like samourai wallet implementation. But this has literally nothing to do with it.

Well, it is very difficult to believe it because scamourai wallet's only goal is to co-opt bitcoin privacy and deanonimize users.

ncoelho commented 2 years ago

Well, it is very difficult to believe it because scamourai wallet's only goal is to co-opt bitcoin privacy and deanonimize users.

I don't understand why do you think this has anything to do with samourai wallet? This was not invented or purpose by them.

It is like saying you don't trust bip32, or bip84, which both samourai and also wasabi use... It is just a bip.

RequestPrivacy commented 2 years ago

This isn't Twitter. Stop spamming this issue with misleading suggestions. If you don't understand what a BIP is go and do some reading before making false claims.

pointbiz commented 2 years ago

In simple English, a Bitcoin address is something you give another person to request a payment from them. The act of giving the address to someone identifies the address belongs to you. That same address is used in the blockchain and anyone can see for free that YOU are receiving transactions.

Reusable payment codes is a new type of address (P address). When you give someone your P address you are identified with it. But this P address never is put in the blockchain. The P address is used to make a.new address that only the sender and receiver know who it belongs to. That new address is used in the blockchain.

This is an extra layer of privacy, it's not perfect privacy. It doesn't stop someone sending you Bitcoin hoping you mix that Bitcoin with other Bitcoin in your wallet during a spend. That happens already without BIP47. And it costs money to try to violate someone's privacy with that technique.

P address allows you to make contacts in your wallet for conveniently sending transactions to the same contact but using fresh addresses every time. Making it easier to avoid address reuse means blockchain analysis firms learn less about your transaction history and patterns.

SuperPhatArrow commented 2 years ago

FWIW I am very keen to add this feature and I had begun working on it when the previous developers said they were going to do it. There are a few things though...

This issue is for BIP47 version 3 & 4 but this BIP is actually not a BIP as far as I can tell. BIP-0047 covers versions 1 & 2 OBPP-05 covers versions 3 & 4

In order to be completely compatible with other wallets, like Samourai Wallet and Sparrow Wallet, which both use version 1, Blue wallet should also use version 1 (for now). The only wallet I have heard of that has implemented v3/4 is a wallet called Métier, which is a work-in-progress afaik. It's from Justus Ranvier (the author of OBPP-05).

@yoshimo is there any particular reason for requesting version 3 & 4 when it is not clear that other wallets will be able to send to Blue Wallet if these versions are implemented? Am I correct in assuming that you just wanted the privacy of Payment Codes and BIP-0047 and a version that is compatible with the BIP (and other wallets) rather than the Latest from OBPP?

Then, the next question is for those that pledged: @yoshimo 150,000 @librepgp 850,000 @acantril 1,000,000 @dav1dpgit 100,000 [Deleted User] [100,000] @johnnywonder1 25,000 @coinsurenz 1,000,000 @modl21 1,000,000 @RequestPrivacy 25,000 @Jorj_X_McKie on Twitter via @librepgp 250,000 Citadel Dispatch matrix group user via @librepgp 1,000,000 @Ziya-Sadr 100,000 @apemithrandir 500,000 @btcuserguide 1,000,000 @BTclaudia 500,000 @ion497 200,000 @Does_not_mattr on Twitter via @librepgp 300,000 @0xAsteria 200,000 @jamesgmorgan 125,000 Meister Eder on Twitter via @librepgp 100,000 @diegoperezcham 475,000 @TheGuySwann 1,000,000 @alaznem 40,000 @FreddyPPFinklemeyerIII 1,000,000 Isaiah Douglass, MBA, CFP on Twitter via @librepgp 500,000 AmBird on Twitter via @librepgp 300,000 Honk Honk MetaMick on Twitter via @librepgp 100,000 @pointbiz 19,500,000

TOTAL: 0.3084BTC

Do your pledges still stand if this is for V1 (compatible) or do you require V3&4 (Probably incompatible) to consider your requirements met?

As for karozagorus, just ignore them. It is their day job to spread FUD about Samourai. Click the links in their profile to see.

BitcoinQnA commented 2 years ago

Put me down for 250k sats

SuperPhatArrow commented 2 years ago

For reference https://twitter.com/SamouraiDev/status/1499796801733419009

btcuserguide commented 2 years ago

Greater compatibility is preferable at this stage so confirming my pledge stands for v1

yoshimo commented 2 years ago

Version 1 is just the beginning and has limitations , both technical and in the number of wallets that support it. Implementing that one would benefit a lot of people but i put the successor on the list in the hope that either we get all of them checked immediately and are one step ahead this time or we at least make the developers aware of the improved draft so that the implementation is prepared and can be enhanced easily later on.

V1 will receive my sats regardless. Extra sats are on the table if obpp-05 and/or reusable taproot adresses get implemented.