search

BlueWallet / BlueWallet

Bitcoin wallet for iOS & Android. Built with React Native
https://bluewallet.io
MIT License
2.62k stars 797 forks source link

BlueWallet Removed from F-Droid #5047

Open jacobranson opened 2 years ago

jacobranson commented 2 years ago

As per the recent discussion in #233, (starting here) the F-Droid builds of BlueWallet have been removed due to the react-native-camera dependency having non-FOSS upstream dependencies. I thought it might be pertinent to open a new issue to track the regression, although the previous issue could be re-opened instead, if the devs prefer.

tomichec commented 1 year ago

It's a real loss that the app is no longer in the F-Droid repository.

Is there any progress on getting it there again? @pointbiz @erfanoabdi @Overtorment

I would be happy to help.

How to find out if the suggested potential replacement is suitable (without non-free dependencies)?

grigio commented 1 year ago

it's a pity that this is still an issue

ghost commented 4 months ago

@Overtorment @marcosrdz @limpbrains Would you please let us know what you intend to do about this?

Is the intention to keep proprietary & uninspected code inside of the app? If so, users need to know so we can start switching to a different wallet.

marcosrdz commented 4 months ago

@Overtorment @marcosrdz @limpbrains Would you please let us know what you intend to do about this?

Is the intention to keep proprietary & uninspected code inside of the app? If so, users need to know so we can start switching to a different wallet.

The whole app is open source.

ghost commented 4 months ago

@marcosrdz Please elaborate.

Is com.google.android.gms:play-services-mlkit-barcode-scanning not a dependency anymore? Has react-native-camera finally been replaced?

This is an important issue, since it affects the inspectability of the code.

pointbiz commented 4 months ago

The whole app is open source.

What's your thoughts on non-FOSS upstream dependencies?

Is it easy or hard to replace this specific react-native-camera dependency?

Would it be helpful if I posted a bounty for it?

marcosrdz commented 4 months ago

@marcosrdz Please elaborate.

Is com.google.android.gms:play-services-mlkit-barcode-scanning not a dependency anymore? Has react-native-camera finally been replaced?

This is an important issue, since it affects the inspectability of the code.

React native camera was replaced a long time ago as that project was abandoned

ghost commented 4 months ago

Amazing! Thank you for the confirmation @marcosrdz

Now let's see if this can be put back in the F-Droid repo.

Overtorment commented 4 months ago

Tbf new camera dep i think also has Google dep. Creating degoogled qr scanner is a bit non trivial, but has been on my radar for a long time, tho not a high priority

ghost commented 4 months ago

Google dependency is okay, as long as all the code is freely available for inspection. This may be how the other wallets on F-Droid are doing it (I'm only guessing).

Let's see what the F-Droid dev says on #233 ...

licaon-kter commented 4 months ago

Google dependency is okay

lol wut? still depends on proprietary Google libs, https://github.com/teslamotors/react-native-camera-kit/blob/master/android/build.gradle#L47

ghost commented 4 months ago

@marcosrdz Please elaborate. Is com.google.android.gms:play-services-mlkit-barcode-scanning not a dependency anymore? Has react-native-camera finally been replaced? This is an important issue, since it affects the inspectability of the code.

React native camera was replaced a long time ago as that project was abandoned

@marcosrdz I'm still seeing references to only react-native-camera in the code. What is the replacement that you mention was put in place a long time ago?

ghost commented 4 months ago

@Overtorment Please feel free to chime in here

marcosrdz commented 4 months ago

@marcosrdz Please elaborate.

Is com.google.android.gms:play-services-mlkit-barcode-scanning not a dependency anymore? Has react-native-camera finally been replaced?

This is an important issue, since it affects the inspectability of the code.

React native camera was replaced a long time ago as that project was abandoned

@marcosrdz I'm still seeing references to only react-native-camera in the code. What is the replacement that you mention was put in place a long time ago?

react-native-camera and react-native-camera-kit are two different projects

ghost commented 4 months ago

So essentially we're in the same place as before? It cannot be proved, for instance, that com.google.mlkit:barcode-scanning does not have malicious code in it, or something that will result in loss of funds.