search

BlueWallet / LndHub

Wrapper for Lightning Network Daemon. It provides separate accounts for end-users
http://LndHub.io
MIT License
765 stars 191 forks source link

LND 0.5.2 balance method not found #14

Closed duckybsd closed 5 years ago

duckybsd commented 5 years ago

When I use my Android blue wallet point to my own LndHub, I can generate lightning payment but seems not able to show the balance, the error log shows:

2019-02-07T10:02:08.714Z '/balance' [ '1cd68f03-37ce-4923-9a71-138c63d9d146' ] (node:35) UnhandledPromiseRejectionWarning: Error: {"result":null,"error":{"code":-32601,"message":"Method not found"},"id":"cbb27d70-7c2f-47e0-8785-f3cf5b36c25a"}

Any idea? Latest LND depreciate "balance" RPC call?

duckybsd commented 5 years ago

Okay, figured out, first time setup, followed the document, it didn't mention I need put my LND wallet password into the config.js password section. Would be nice if the document can be updated to help newbies like me.

Overtorment commented 5 years ago

Sorry about that! It is expected that lnd wallet is already unlocked when Lndhub launches. I only recently added automatic wallet unlock in code, for a case if everything crashes and restarts automatically. Will update the doc. Lmk if you have other questions, will be happy to help

On Thu, Feb 7, 2019 at 10:39 duckybsd notifications@github.com wrote:

Okay, figured out, first time setup, followed the document, it didn't mention I need put my LND wallet password into the config.js password section. Would be nice if the document can be updated to help newbies like me.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BlueWallet/LndHub/issues/14#issuecomment-461368984, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0x-fxBNgM5a3FPQ2N37Asb78e-WKxtks5vLAJygaJpZM4am_xp .

duckybsd commented 5 years ago

Sorry about that! It is expected that lnd wallet is already unlocked when Lndhub launches. I only recently added automatic wallet unlock in code, for a case if everything crashes and restarts automatically. Will update the doc. Lmk if you have other questions, will be happy to help … On Thu, Feb 7, 2019 at 10:39 duckybsd @.***> wrote: Okay, figured out, first time setup, followed the document, it didn't mention I need put my LND wallet password into the config.js password section. Would be nice if the document can be updated to help newbies like me. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0x-fxBNgM5a3FPQ2N37Asb78e-WKxtks5vLAJygaJpZM4am_xp .

Yes, the LND wallet already unlocked, still I have to put this password in config

duckybsd commented 5 years ago

Sorry to bother, I still have the same error, but my Zap wallet has no problem at all. So, I think it's not my lightning node's problem.

2019-02-07T10:44:44.841Z '/balance' [ '7a44b1ca-6dc8-4446-8a51-010e9fe837b9' ] (node:34) UnhandledPromiseRejectionWarning: Error: {"result":null,"error":{"code":-32601,"message":"Method not found"},"id":"f7841eed-bdba-4ceb-9da4-aa9241069fbf"}

Overtorment commented 5 years ago

Ok, most likely the issue is that bitcoind needs to be run with -deprecatedrpc=accounts switch. Gona add it to documentation.

In case if thats not it, /balance call relies on:

Mazon commented 5 years ago

same issue for me on /balance. have set deprecatedrpc=accounts in bitcoind config

duckybsd commented 5 years ago

Same here, no luck.

Environment:

Bitcoin Core 0.17.1
LND 0.5.2 beta

Zap 0.3.4 has no problem with full function

Error:

2019-02-09T04:43:32.152Z '/balance' [ 'df740f07-c4d3-4e87-9506-4491730f5cf3' ]
(node:32) UnhandledPromiseRejectionWarning: Error: {"result":null,"error":{"code":-32601,"message":"Method not found"},"id":"6fcbfbe7-e47f-4162-bc31-312ca1975a28"}

    at IncomingMessage.<anonymous> (/usr/src/app/node_modules/jayson/lib/client/http.js:74:21)
    at IncomingMessage.emit (events.js:202:15)
    at IncomingMessage.EventEmitter.emit (domain.js:439:20)
    at endReadableNT (_stream_readable.js:1129:12)
    at processTicksAndRejections (internal/process/next_tick.js:76:17)
(node:32) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
alerobrod commented 5 years ago

I run with Bitcoin Core: 0.17.0. Reading up on release notes for 0.17.1 it seems 'listtransactions' method has changed again (in relation to the use of -deprecated=accounts). Wonder if anything to do with it as I also had issues (read bug #12) and resolved it by pull request #13.

I don't have possibility to upgrade now to 0.17.1 (and reproduce) but perhaps you could try using curl for this method? E.g.:

curl -v --data-binary '{"jsonrpc":"1.0","id":"curltext", "method":"listtransactions","params": ["*", 10 , 0, true] }' -u <RPC user:passwd> -H 'content-type: text/plain;' http://<RPC IP e.g 127.0.0.1>:<RPC port e.g. 8332>

The first parameter try and use also a valid bitcoin address and not only the dummy ("*") value. The release notes for 0.17.1 describe what is supported here depending on the use of -deprecatedrpc=accounts when starting bitcoind so perhaps a certain combination may allow to reproduce.

Also, you could try and add some debug (console) statements to both ./controller/api.js and ./class/User.js and see where it actually fails (perhaps is not the mentioned method that fails).

Good luck and post any findings as at some point I am planning on upgrading (including the version of LND you are using; me the previous one 0.5.1-beta).

Overtorment commented 5 years ago

Makes sense. Production system runs bitcoin-0.17.0 and lnd 0.5.1-beta

On Sat, 9 Feb 2019 at 13:27, alerobrod notifications@github.com wrote:

I run with Bitcoin Core: 0.17.0. Reading up on release notes for 0.17.1 it seems 'listtransactions' method has changed again (in relation to the use of -deprecated=accounts). Wonder if anything to do with it as I also had issues (read bug #12 https://github.com/BlueWallet/LndHub/issues/12) and resolved it by pull request #13 https://github.com/BlueWallet/LndHub/pull/13.

I have possibility to upgrade now to 0.17.1 and reproduce but perhaps you could try using curl for this method? E.g.:

curl -v --data-binary '{"jsonrpc":"1.0","id":"curltext", "method":"listtransactions","params": ["*", 10 , 0, true] }' -u <RPC user:passwd> -H 'content-type: text/plain;' http://<RPC IP e.g 127.0.0.1>:<RPC port e.g. 8332>

The first parameter try and use also a valid bitcoin address and not only the dummy value. The release notes for 0.17.1 describe what is supported here depending on the use of -deprecated=accounts when starting bitcoind so perhaps a certain combination may allow to reproduce.

Also, you could try and add some debug (console) statements to both ./controller/api.js and ./class/User.js and see where it actually fails (perhaps is not the mentioned method that fails).

Good luck and post any findings as at some point I am planning on upgrading (including the version of LND you are using; me the previous one 0.5.1-beta).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BlueWallet/LndHub/issues/14#issuecomment-462044507, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0x-VkDnffbd5QwwQRwJllgbr1lXyOhks5vLszMgaJpZM4am_xp .

duckybsd commented 5 years ago

@alerobrod

You are a champion. Your "curl" command saved the day! After I executed the command, I realized that I have disablewallet=1 in my bitcoin.conf, the reason for this is I was set up the lightning only node before, there is no point to enable Bitcoin wallet, I am using Bitcoin core as only broadcasting TX. After comment this, now it's fully functioning now! Even with bitcoin-0.17.1 and lnd 0.5.2-beta

Well done, blue wallet.

Overtorment commented 5 years ago

Great! Thanks all!

On Sun, 10 Feb 2019 at 03:59, duckybsd notifications@github.com wrote:

Closed #14 https://github.com/BlueWallet/LndHub/issues/14.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BlueWallet/LndHub/issues/14#event-2129036235, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0x-ay-JhXRUhg5NOgBBVoJK6ctz9Luks5vL5kYgaJpZM4am_xp .