Closed lndhub-admin closed 2 years ago
Really?
no issues all good, erlier before this patch the thing is Paym.js is a class and referenced a static constant from user.js and api.js and problem was having to reach a regular variable in api.js when Paym.js instantiated without having to refactor much more then we now try do .
so all good and works . You can try it with UI checking out branch Admin-Extension-router . build and run ... https://github.com/lndhub-admin/LndHub/tree/Admin-Extension-router
OK
so i added 2 lines in config.js and 2 lines in controllers/api.js = 4 lines
that enables fee settings at startup from config.js and also opens up for dynamic fee settings at runtime.
i also reduced LOC by 3 by deleting 3 lines in Paym.js
total add LOC 1, i myself regard that as rather elegant for the amount added functionality while not refactor wildly.
to be able continue https://github.com/lndhub-admin/LndHub-Admin-Extension i find the wait for PR's here are very slow and hinders more of PR's i would like to suggest namely
this all means LndHub core can be frozen while enabling being highly extensible
are you asking me to hard fork ? or is it that You se any problems with this PR ?
thanks
This allows for setting fees in config.js that will be read and set at startup.
The changes also allows for dynamic fee settings at runtime through Extension Admin API, demonstrated in a follow up PR to this one will be a example UI admin extension.