BlueWallet / LndHub

Wrapper for Lightning Network Daemon. It provides separate accounts for end-users
http://LndHub.io
MIT License
751 stars 185 forks source link

Lndhub Fee #27

Open ohenrik opened 5 years ago

ohenrik commented 5 years ago

Quick question: Does the default LndHub take a fee? Ref these lines:

https://github.com/BlueWallet/LndHub/blob/92f1370dbade2de12719f3bc043f8b7a433de38e/controllers/api.js#L166-L175

Does this mean that if users on my lndhub spend 1000 sat, my hub earns 10 sat?

If so, i think this should be configurable. I can add contribute with this if needed.

Overtorment commented 5 years ago

You are correct. I added this recently. Havent thought about proper place for this configuration, so dont rush

On Tue, Mar 12, 2019 at 16:37 Ole Henrik Skogstrøm notifications@github.com wrote:

Quick question: Does the default LndHub take a fee? Ref this line:

https://github.com/BlueWallet/LndHub/blob/92f1370dbade2de12719f3bc043f8b7a433de38e/controllers/api.js#L173

Does this mean that in users on my lndhub spend 1000 sat, my hub earns 10 sat?

If so, i think this should be configurable. I can add contribute with this if needed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BlueWallet/LndHub/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0x-df2AL28-YZQ07pxNzc1PWlyUmOpks5vV9fbgaJpZM4brWwe .

lessless commented 4 years ago

@Overtorment is it safe to set fee to 0?

Overtorment commented 4 years ago

@lessless I think so

lndhub-admin commented 3 years ago

could perhaps be resolved with set fees in config at startup #238