search

BlueWallet / LndHub

Wrapper for Lightning Network Daemon. It provides separate accounts for end-users
http://LndHub.io
MIT License
752 stars 185 forks source link

partnerid mandatory or not? #296

Closed MG-ng closed 2 years ago

MG-ng commented 2 years ago

It say in the LndHub/doc/Send-requirements.md

"partnerid" : "bluewallet" // string, not mandatory parameter

But in the code it seems like it has to exist and has to be equals "bluewallet". https://github.com/BlueWallet/LndHub/blob/35fe816d0aa5047653c2ff90d800ef146c31292c/controllers/api.js#L136

Is it intended to be that way, so that every alternative partner has to adjust this code or just use the bluewallet partnerid resulting in a useless parameter? Or am I reading the code wrong? (I am not that familiar with nodejs)

Thanks for your reply :)

Overtorment commented 2 years ago

its a bug. this should be relaxed and partnerid should be any string.

MG-ng commented 2 years ago

Okay, thank you for your clarification. Should I make a pull request?

Overtorment commented 2 years ago

sure

MG-ng commented 2 years ago

297