search

BlueWallet / LndHub

Wrapper for Lightning Network Daemon. It provides separate accounts for end-users
http://LndHub.io
MIT License
745 stars 180 forks source link

Please add the description to payinvoice endpoint, if payment_request uses deschash #540

Open rustyrussell opened 1 year ago

rustyrussell commented 1 year ago

Hi!

I'm trying to ensure nodes see the full invoice they're paying, but as of now that's not possible with the current LndHub protocol, since you only hand the bolt11 string which may not contain the description (LNURL particularly likes to use the h description_hash field).

This is a real problem for node validation, since they don't know what they're paying, and for users who can't query their node to see what they actually paid (especially if they use multiple front-ends).

(Note: I discovered this issue because lnbits actually has an LndHub extension which means you can actually use BlueWallet to drive CLN, which is :fire: :open_mouth: and @CalleBTC reported it in https://github.com/ElementsProject/lightning/pull/6092#issuecomment-1466929896).

joycekerkhof commented 4 months ago

Can you explain this for me please?