socket-security[bot]
commented
1 year ago 🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎
To accept the risk, merge this PR and you will not be notified again.
| Issue | Package | Version | Note | Source |
|---|---|---|---|---|
| Network access | simple-update-notifier | 1.1.0 |
|
package-lock.json via nodemon@2.0.22 |
| Network access | express | 4.18.2 |
|
package-lock.json, package.json |
Next steps
What is network access?
This module accesses the network.
Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.
Take a deeper look at the dependency
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
Remove the package
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
Mark a package as acceptable risk
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all
@SocketSecurity ignore simple-update-notifier@1.1.0@SocketSecurity ignore express@4.18.2
Why (The need)
We have a custom project and lndhub.io running with the same lightning node, but lndhub does not allow payment of invoices which were not issued by lndhub (but have the same lightning node as destination) See Code.
It's our development server and we want to avoid setting up an extra node+channels. It's an effort we don't wanna do. So we thought of adding the self payment feature to lndhub.io.
What did I change?
allowLightningPaymentToNodedefaulting tofalsefalsethere is a new error messageThis LNDHub instance does not allow payments other then issued by LNDHub.truethe self payment flag is added to the lnd grpc call. It still can fail because of LND, but it in most cases it does work.