BluebirdGreycoat / musttest_game

Other
1 stars 1 forks source link

QoL: chest formspecs #9

Closed hlqkj closed 3 months ago

hlqkj commented 3 months ago

Hello, this adds the following "features" to chest_api:

The code should be ready for review.

I tried to isolate the features in separate commits such that, by the magics of git, they could somehow be cherry-picked as needed, may something be unwanted. Otherwise, a squash would be advisable!

Thanks for considering this.


Notes:

1) It may be a little harsh that when sending the easyvend error sound to the client, the standard formspec 'click' sound is also sent and the two overlap. I could not figure how to prevent the 'click' sound from being sent, if that's possible at all?

2) This commit contains some severe ugliness, but it's a take-it-or-leave-it. Doing it properly would require too much effort (a per-player context) which would not be worth for the little benefit it gives in the game, which is, saving a few keystrokes. Please double-check it. I tried to better explain in the code itself (see the comment).

BluebirdGreycoat commented 3 months ago

Wow, thanks!

Regarding the "More QoL, but at what price" commit: there is a player context already available, but it's cheaper for me to just fix that bit of the code than to muck around with git's cherry-picker.

hlqkj commented 3 months ago

Thank you! (And, perfect fix to the players list ugly commit :))