Blueforcer / awtrix3

Custom firmware for the Ulanzi Smart Pixel clock or self made awtrix. Getting started is easy as 1-2-3
https://blueforcer.github.io/awtrix3/
Other
1.41k stars 112 forks source link

[BUG] Icon is not displayed again with pushIcon=2 #316

Closed pherga closed 1 year ago

pherga commented 1 year ago

Related, maybe, to the previous bug I reported last week with textOffset, if pushIcon = 2 on an MQTT payload the icon does not return on subsequent passes. Instead, The icon is displayed when the text in offset reaches the location of the icon.

Steps to Reproduce:

  1. Publish the following payload: { "text": "Good Night", "repeat" : 3, "pushIcon" : 2, "textOffset" : 33, "icon" : "w-clear-night" }

Expected Behavior After the first pass, the icon should return while the text starts scrolling again.

Actual Behavior On the second or any subsequent passes the icon does not return. Instead it is displayed only when the text reaches the location of the icon.

Screenshots awtrix

Blueforcer commented 1 year ago

Crazy that's what I've fixed.. let me check this

Blueforcer commented 1 year ago

Set "textOffset" : 22

pherga commented 1 year ago

Yup. textOffset=22 does work as expected.

Blueforcer commented 1 year ago

i will try to limit it for the calculations in the next version

pherga commented 1 year ago

Thank you so much, Stephan. Keep it up! 💪🏻