Blueforcer / awtrix3

Custom firmware for the Ulanzi Smart Pixel clock or self made awtrix. Getting started is easy as 1-2-3
https://blueforcer.github.io/awtrix3/
Other
1.41k stars 112 forks source link

[FEATURE REQUEST] Allow to adjust volume for DFPlayer #419

Closed Lutty76 closed 10 months ago

Lutty76 commented 11 months ago

Feature Request

Is your feature request related to a problem?

My problem is that I cannot adjust volume

Describe the solution / feature you'd like

In global.cpp you have this

#ifndef ULANZI
    Settings.putUInt("VOL", VOLUME_PERCENT);

and this

#ifndef ULANZI
    VOLUME_PERCENT = Settings.getUInt("VOL", 50);
    VOLUME = map(VOLUME_PERCENT, 0, 100, 0, 30);

but we can't set this setting for api as this variable doesn't exist in DisplayManager.cpp so you just put default value (50) in setting and reload it

Describe alternatives you've considered

Just add :

VOLUME_PERCENT = doc.containsKey("VOL") ? doc["VOL"].as<int>() : VOLUME_PERCENT ; in DisplayManager_::setNewSettings for allow use to change volume

Additional context

Add any other context or screenshots about the feature request here.

Blueforcer commented 11 months ago

Currently you can set the volume via onscreen menu

Lutty76 commented 11 months ago

I don't have plugged the screen for the moment 😅 so i didn't see this thanks for information. But can be done by API should be a good thing, no ?

Blueforcer commented 10 months ago

https://github.com/Blueforcer/awtrix-light/releases/tag/0.92