Bluegrams / YoutubeDLSharp

A simple .NET wrapper library for youtube-dl and yt-dlp
BSD 3-Clause "New" or "Revised" License
173 stars 30 forks source link

Add a second "RunWithOptions" Method that returns the standard RunResult<string> and accepts IProgress parameters #12

Closed adanvdo closed 2 years ago

adanvdo commented 2 years ago

I was needing to do some post-processing on audio-only formats and the RunAudioDownload method was not able to do what I needed. RunWithOptions was able to do it, but I ran into a couple things that were problematic in my project.

This change implements a second RunWithOptions method that accepts the standard parameters used by the other download methods and returns a clean Download Location.

alxnull commented 2 years ago

Hey @adanvdo, thanks for opening this PR and sorry for the long response time. Your description of the changes sound reasonable and I'm happy to merge that. However, it seems you added further changes to this branch in the meantime. Would be great if you could disentangle the originally described changes so I can merge those first.

Of course I'm also happy to merge further changes from your side back to this repo afterwards (hopefully with a shorter review and merge time).