Bluehouse-Technology / otter

Support for OpenTracing in Erlang
https://hexdocs.pm/otter/
Apache License 2.0
104 stars 17 forks source link

export_all vs export #6

Closed Licenser closed 7 years ago

Licenser commented 7 years ago

Would there be objections to a PR that makes exports explicit?

Partially this comes down to taste I guess, but in my experience having explict exports makes understanding code a lot easier (i.e. you can just read over the exports to see the external API), as well as it makes dead code more obvious (unused functions that are neither exported nor used locally).

tsloughter commented 7 years ago

In OTP 20 export_all becomes a warning, so best to remove them.

cmullaparthi commented 7 years ago

Yep, fixed in the 0.2.0 release.