Blueprints-org / blueprints

Blueprints, open source python package for civil engineering calculations.
https://blueprints.readthedocs.io
GNU Lesser General Public License v2.1
15 stars 2 forks source link

[✨ Feature request]: Add formula 5.15 from NEN_EN_1992_1_1_C2_2011 #167

Closed bro-wi closed 4 months ago

bro-wi commented 7 months ago

Description

Add formula 5.15 from NEN_EN_1992_1_1_C2_2011

Image afbeelding

Acceptance Criteria

Dependencies

not applicable

Confirmation

MaartenBW commented 6 months ago

@bro-wi and @egarciamendez In this equation, there are K1 and K2. But these k-factor is defined by another equation in the defenition. Would i implement the equations with the k factors or the underlying inputs for those k-factors (twice).

I would opt for the first option. and maybe implement the formula for the k-factor seperately.

what do you guys think?

egarciamendez commented 6 months ago

Good question @MaartenBW , In those cases we usually make it possible to 'insert' your own calculated value. For example values for k1 and k2 previously calculated outside this class and when a formula for those values are present inside Blueprints then link them in the docstring. See this example from formula 2.1a: afbeelding

bro-wi commented 6 months ago

I agree with Enrique. Because the equations for k1 and k2 are not 'numbered' or 'labeled' you can have a look at this file, where it is called a 'SubFormula' :

blueprints/codes/eurocode/nen_en_1992_1_1_c2_2011/chapter_3_materials/formula_3_4.py

MaartenBW commented 6 months ago

thanks, this was what i was looking for

egarciamendez commented 5 months ago

Hi Maarten, do you need any help with this one?