search

Bluespess / tgstation-remake

https://ss13.io
GNU Affero General Public License v3.0
26 stars 14 forks source link

More medicine #45

Closed ike709 closed 6 years ago

ike709 commented 6 years ago

I've now gone through the entire file. Most TODOs couldn't be done because of either my stupidity or something not being implemented. The primary cause of the latter is the lack of AdjustStun(), AdjustKnockdown(), and AdjustUnconscious().

Most chemicals are fully implemented, but a significant minority are missing mob_life(), reaction_mob() or overdose_process()

Also I'd like to point out that I've tested literally none of the medicine added in this PR or the previous PR. At least it doesn't throw an error when I run the server.

ike709 commented 6 years ago

I bet I messed up some dt stuff somewhere.

ike709 commented 6 years ago

add() and remove() should almost certainly be renamed to add_reagent() and remove_reagent() at some point. It'd also be nice if a has_reagent() proc existed to simplify the process of checking for a reagent. EDIT: That last bit seems to exist actually.

ike709 commented 6 years ago

That's probably right.

ike709 commented 6 years ago

inb4 there's more fuckups involving dt