This entire thing is shitcode.

Bluespess / tgstation-remake

https://ss13.io

GNU Affero General Public License v3.0

26 stars 14 forks source link

This entire thing is shitcode. #76

Open PJB3005 opened 5 years ago

PJB3005 commented 5 years ago

I reviewed 500 lines of code and I'm already convinced this entire repo is parody to make BYOND SS13 look good.

https://pastebin.com/3maDpVwU

ghost commented 5 years ago

if this “””shitcode””” offends you so much and you can easily pinpoint what’s so wrong with it, open a few PRs or something. it’s good to point out errors, but you’re way too emotionally charged over this. put that into something beneficial and constructive.

PJB3005 commented 5 years ago

open a few PRs or something

I have my own projects to work, thank you very much. Also for me to even begin cleaning up this hot mess would need TypeScript, which is a giant refactor at this point. And since Monster is clearly 100% apathic to how completely unmaintainable his code is, ¯\_(ツ)_/¯

but you’re way too emotionally charged over this.

It's more like this actually.

put that into something beneficial and constructive.

I already did, this report and bluespess/bluespess#1. Of course I also know it falls on deaf ears.

ghost commented 5 years ago

few projects of my own

didn’t see you contribute to ss14, good luck with that.

typescript

i’m completely unfamiliar with TS, what’s the point of it and what does it do again?

PJB3005 commented 5 years ago

i’m completely unfamiliar with TS, what’s the point of it and what does it do again?

It gives JS static typing also known as ability-to-maintain-your-code-at-all

Altoids1 commented 5 years ago

It's more like this actually.

It's actually more like this: