search

Bluetooth-Devices / bluetooth-data-tools

Tools for converting bluetooth data and packets
Apache License 2.0
4 stars 5 forks source link

What is `address_to_bytes` used for? #53

Open akx opened 3 months ago

akx commented 3 months ago

The test for address_to_bytes looks pretty suspect:

https://github.com/Bluetooth-Devices/bluetooth-data-tools/blob/daac28de645075625410138988832c8d0f644aea/tests/test_utils.py#L27

– why would bytes-ifying a 6-octet string result in 4 binary bytes?

That said, it doesn't look like anything within the library uses the (possibly broken?) function. Should it be removed?

bdraco commented 3 months ago

I think one of the ble libs uses it but I can remember which one for the life of me