Closed thecode closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.60%. Comparing base (
113e49d
) to head (6cc0f60
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have one minor comment, I think we should have a colon after the name/title of the device. E.g.
ATC 18B2 New packet_id 9 indicates an older packet (previous packet_id 9).
should be
ATC 18B2: New packet_id 9 indicates an older packet (previous packet_id 9).
Sorry for this, but we can better do it correct now.
I have one minor comment, I think we should have a colon after the name/title of the device. E.g.
ATC 18B2: New packet_id 9 indicates an older packet (previous packet_id 9).
Good point, fixing
I have a Shelly device with a buggy firmware which constantly log this message:
The message doesn't help identifying the device (although I know it is one of two devices) and in use case of multiple devices it would be hard to identify which device is logging the message and may be confusing when trying to analyze logs.
Added device title where it is possible and added/modified tests to cover the log messages