search

Bluetooth-Devices / bthome-ble

Parser for BTHome BLE devices
https://bthome.io/
MIT License
79 stars 16 forks source link

Allow one encryption counter reset per 100 messages to allow changing… #117

Closed Komzpa closed 7 months ago

Komzpa commented 8 months ago

… batteries and brownouts in devices

Attempt to fix #116. Thanks ChatGPT for help. Did not try running this, please review if this makes sense.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.11%. Comparing base (303f833) to head (69a1fa0). Report is 1 commits behind head on main.

:exclamation: Current head 69a1fa0 differs from pull request most recent head b53d8d7. Consider uploading reports for the commit b53d8d7 to get more accurate results

Files Patch % Lines
src/bthome_ble/parser.py 57.14% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #117 +/- ## ========================================== - Coverage 83.84% 83.11% -0.74% ========================================== Files 6 6 Lines 520 533 +13 Branches 79 82 +3 ========================================== + Hits 436 443 +7 - Misses 68 73 +5 - Partials 16 17 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Komzpa commented 7 months ago

I managed to run this on my instance and it does not yet fix the issue. Will continue torturing this.

image

Komzpa commented 7 months ago

I believe version in #119 came out a lot nicer than this approach.