Bluetooth-Devices / bthome-ble

Parser for BTHome BLE devices
https://bthome.io/
MIT License
69 stars 14 forks source link

Remove object format length byte #17

Closed Ernst79 closed 1 year ago

Ernst79 commented 1 year ago

Remove object format and length byte

To safe bytes, this PR removes the object format and length byte and will use a fixed format and length for each measurement type.

ToDo

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.93% // Head: 73.65% // Decreases project coverage by -2.27% :warning:

Coverage data is based on head (2f43a29) compared to base (54547ab). Patch coverage: 69.44% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## V2 #17 +/- ## ========================================== - Coverage 75.93% 73.65% -2.28% ========================================== Files 5 6 +1 Lines 349 429 +80 Branches 57 61 +4 ========================================== + Hits 265 316 +51 - Misses 65 91 +26 - Partials 19 22 +3 ``` | [Impacted Files](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/bthome\_ble/bthome\_v1\_encryption.py](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J0aG9tZV9ibGUvYnRob21lX3YxX2VuY3J5cHRpb24ucHk=) | `61.64% <ø> (ø)` | | | [src/bthome\_ble/bthome\_v2\_encryption.py](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J0aG9tZV9ibGUvYnRob21lX3YyX2VuY3J5cHRpb24ucHk=) | `61.33% <61.33%> (ø)` | | | [src/bthome\_ble/parser.py](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J0aG9tZV9ibGUvcGFyc2VyLnB5) | `78.37% <87.09%> (+0.25%)` | :arrow_up: | | [src/bthome\_ble/const.py](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J0aG9tZV9ibGUvY29uc3QucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.