Bluetooth-Devices / bthome-ble

Parser for BTHome BLE devices
https://bthome.io/
MIT License
67 stars 12 forks source link

feat: add possibility to include mac in payload #48

Closed Ernst79 closed 1 year ago

Ernst79 commented 1 year ago

feat: add possibility to include mac in payload (fix for #42)

codecov[bot] commented 1 year ago

Codecov Report

Base: 74.60% // Head: 75.11% // Increases project coverage by +0.50% :tada:

Coverage data is based on head (e7490b4) compared to base (27e5982). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 74.60% 75.11% +0.50% ========================================== Files 6 6 Lines 445 450 +5 Branches 67 68 +1 ========================================== + Hits 332 338 +6 + Misses 91 90 -1 Partials 22 22 ``` | [Impacted Files](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/bthome\_ble/\_\_init\_\_.py](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J0aG9tZV9ibGUvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/bthome\_ble/parser.py](https://codecov.io/gh/Bluetooth-Devices/bthome-ble/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2J0aG9tZV9ibGUvcGFyc2VyLnB5) | `80.28% <100.00%> (+0.72%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mmeruje commented 1 year ago

Looks good! Running tests on my side worked. When doing that I also added (locally) a test case with data collected from one of our sensors.

A suggestion - if this is an isolated case - rather than changing the whole flake8 max-line-length setting to 106 just because of this line, you could use an inline comment for flake8 to ignore the error in that specific line: # noqa: E501.

Cheers!

Ernst79 commented 1 year ago

Thanks for checking. Fixed your comment, that is indeed a better solution. flake8 and black where changing each other back and forth.