Mac workaround can likely come out now

Bluetooth-Devices / bthome-ble

Parser for BTHome BLE devices

https://bthome.io/

MIT License

67 stars 12 forks source link

Mac workaround can likely come out now #62

Closed bdraco closed 5 months ago

bdraco commented 1 year ago

https://github.com/Bluetooth-Devices/bthome-ble/blob/f9d532b4562076f90693cc7cacdb463f26cba335/src/bthome_ble/parser.py#L122

HA now enables the flag to give the real mac

Ernst79 commented 1 year ago

So, the mac address is now always available in the data, also on a mac?

koenvervloesem commented 1 year ago

This won't work always, I have seen a program crash when enabling this feature with Bleak on a macOS version that doesn't support the undocumented API.

Ernst79 commented 10 months ago

@bdraco So, based on the message of @koenvervloesem, should we keep the MAC workaround in for now?

bdraco commented 10 months ago

We have the bdaddr featured turned on unconditionally in HA and don't have any plans to support older MacOS so I think it can come out