Closed Ernst79 closed 1 year ago
Patch coverage: 100.00
% and project coverage change: -0.10
:warning:
Comparison is base (
e6c192c
) 77.66% compared to head (93c8baa
) 77.56%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Is the bindkey getting set outside of init ?
Ideally we don't want to recreate the object every time we decrypt a packet as it will likely be MUCH slower
I fixed it in https://github.com/Bluetooth-Devices/bthome-ble/pull/83
Ideally we don't want to recreate the object every time we decrypt a packet as it will likely be MUCH slower
Yes, that what I also thought, but couldn't think of a better solution. Thanks!
HA was failing in the config flow tests with 2.13.0 on this part of the code when using encryption
I move the cipher part down to the decryption function. Not sure is this is the best way to solve it, but the HA tests do work with this change.