Ernst79
commented
11 months ago Yes, I think this is right repo where your issue is related to.
However, I'm trying to understand why this issues occurs. The code that is causing this behavior is the following .
if name == service_info.address:
name = "BTHome sensor"
# Remove identifier from ATC sensors name.
atc_identifier = (
service_info.address.replace("-", "").replace(":", "")[-6:].upper()
)
if name[-6:] == atc_identifier:
name = name[:-6].rstrip(" _")
...
# Try to get manufacturer based on the name
if name.startswith(("ATC", "LYWSD03MMC")):
manufacturer = "Xiaomi"
device_type = "Temperature/Humidity sensor"
elif name.startswith("prst"):
manufacturer = "b-parasite"
name = "b-parasite"
device_type = "Plant sensor"
elif name.startswith("SBBT"):
manufacturer = "Shelly"
name = "Shelly BLU Button1"
device_type = "BLU Button1"
elif name.startswith("SBDW"):
manufacturer = "Shelly"
name = "Shelly BLU Door/Window"
device_type = "BLU Door/Window"
else:
manufacturer = None
device_type = "BTHome sensor"
# Get device information from local name and identifier
self.set_device_name(f"{name} {identifier}")
self.set_title(f"{name} {identifier}")
self.set_device_type(device_type)The name input is service_info.name in the script. It this would have been ATC_BUIRO, I would expect that the final name would have been ATC_BUIRO 0745
- It will not pass the check
if name == service_info.address(as the address is the mac address) - It will also fail the check
if name[-6:] == atc_identifier(as the atc_identifier is the last 6 characters of the MAC, which is not the same as_BUIRO.
So, I suspect that the service_info.name is not returning what we expect. I'll have to dig deeper into this
Misiu
pvvx
bdraco
Describe the bug I've flashed LYWSD03MMC with 4.5 firmware using https://pvvx.github.io/ATC_MiThermometer/TelinkMiFlasher.html. I've set the device name via the page, and now every time I want to connect the flasher I see my device on the list:
(ACT_BIURO)
I've also set the advertisement type to BTHome v2, and soon after the device was discovered in Home Assistant, but sadly the device presented on the list didn't have the name I've set in the Flasher:
I've created an issue in pvvx repo - https://github.com/pvvx/ATC_MiThermometer/issues/426, but apparently, the issue is on the HA side.
After flashing 5 or more devices and moving them to the destination home right now we must power one device at a time, having the device name in the discovery information it would be easy to set up all the devices at once.
To Reproduce Steps to reproduce the behavior: Flash LYWSD03MMC with firmware 4.5, set custom device name, set BTHome v2 as advertisement type go to integrations in HA and observe the newly found device with the wrong name
Additional context I'm using HA 2023.11.3 and a couple of Shelly devices as BT Proxy. I've tried active scanning, and passive scanning, restarted Shelly devices, and restarted HA, but nothing helped.
I think this is a related issue: https://github.com/home-assistant/core/issues/79468
If the issue is not created in the right repo please move it to the right place or let me know and I'll create a new one in the right place.