Closed bdraco closed 1 year ago
Patch coverage: 25.00%
and project coverage change: +0.04%
:tada:
Comparison is base (
c40c7bc
) 82.46% compared to head (72d6d67
) 82.51%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
peek does more than peek
It can actually READ!
https://github.com/python/cpython/blob/f106254e0b3c83d9064763d6132b3fe997da901b/Lib/_pyio.py#L1151
this is so much better for small messages but kills performance for large ones
I'm not sure this is going to work since there is no public method to peek that does not cause a read to happen
Its not worth the change risk unless we can actually avoid the syscall
If we know
_unmarshall
will internally raiseEOFError
viapeek
, we now return and wait until asyncio calls us again to read