search

Bluetooth-Devices / dbus-fast

A faster version of dbus-next
MIT License
37 stars 8 forks source link

feat: optimize passive bluez message unmarshaller #216

Closed bdraco closed 1 year ago

bdraco commented 1 year ago

This is ~3% speed up

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.18% :tada:

Comparison is base (d771bcf) 82.52% compared to head (c6e9b78) 82.71%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #216 +/- ## ========================================== + Coverage 82.52% 82.71% +0.18% ========================================== Files 27 27 Lines 3211 3216 +5 Branches 665 666 +1 ========================================== + Hits 2650 2660 +10 + Misses 343 341 -2 + Partials 218 215 -3 ``` | [Files Changed](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices) | Coverage Δ | | |---|---|---| | [src/dbus\_fast/\_\_version\_\_.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9fX3ZlcnNpb25fXy5weQ==) | `0.00% <0.00%> (ø)` | | | [src/dbus\_fast/\_private/unmarshaller.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9fcHJpdmF0ZS91bm1hcnNoYWxsZXIucHk=) | `95.95% <100.00%> (+0.05%)` | :arrow_up: | | [src/dbus\_fast/signature.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9zaWduYXR1cmUucHk=) | `62.11% <100.00%> (-0.17%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/216/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 1 year ago

All good overnight