Bluetooth-Devices / dbus-fast

A faster version of dbus-next
MIT License
37 stars 8 forks source link

fix: avoid cythonizing SendReply #232

Closed bdraco closed 1 year ago

bdraco commented 1 year ago

This is a workaround since context managers currently have an issue with Cython 3

fixes #229

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% :tada:

Comparison is base (ed5c87f) 82.58% compared to head (3fac7e3) 82.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== + Coverage 82.58% 82.71% +0.12% ========================================== Files 27 28 +1 Lines 3251 3257 +6 Branches 673 673 ========================================== + Hits 2685 2694 +9 + Misses 346 345 -1 + Partials 220 218 -2 ``` | [Files Changed](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices) | Coverage Δ | | |---|---|---| | [src/dbus\_fast/message\_bus.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9tZXNzYWdlX2J1cy5weQ==) | `71.63% <100.00%> (-0.30%)` | :arrow_down: | | [src/dbus\_fast/send\_reply.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9zZW5kX3JlcGx5LnB5) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/232/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 1 year ago

Performance impact is effectively zero for Bluez DeviceFound messages since there is no reply

This seems like it will be fine.

Tested on production and no side effects observed (wouldn't expect it from moving code around)