Closed dlech closed 12 months ago
Patch coverage: 50.00%
and project coverage change: +0.03%
:tada:
Comparison is base (
14f52f2
) 82.81% compared to head (d2a0104
) 82.84%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Technically, this is an API breaking change, but I think the only thing it would break is:
import dbus_fast
dbus_fast.aio.something
or
from dbus_fast import *
aio.something
which I hope would be quite rare.
We should probably mark it as a breaking change.
Testing this now
Pushed to all my production. Nothing broke. Let's hope thats the case for everyone else
Thanks @dlech
Everything was ok with the dep bump except bleak
bleak 0.21.0 depends on dbus-fast<2.0.0 and >=1.83.0; platform_system == "Linux"
Since the top-level
__init__.py
is always imported when any subpackage is imported, this caused both backends (glib and aio) to always be imported. This is not desirable, since it means that the glib backend will always be imported, even if the user only wants to use the aio. This wastes resources and in some cases can even cause a crash.Fixes: https://github.com/Bluetooth-Devices/dbus-fast/issues/242