Bluetooth-Devices / dbus-fast

A faster version of dbus-next
MIT License
35 stars 8 forks source link

feat: add cython typing for ServiceInterface.name #248

Closed bdraco closed 12 months ago

bdraco commented 12 months ago

We compare this a lot so we want to force __Pyx_PyUnicode_Equals

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.22% :warning:

Comparison is base (8f39ba3) 83.60% compared to head (975dcd6) 83.38%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== - Coverage 83.60% 83.38% -0.22% ========================================== Files 28 28 Lines 3263 3263 Branches 677 677 ========================================== - Hits 2728 2721 -7 - Misses 324 328 +4 - Partials 211 214 +3 ``` | [Files Changed](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices) | Coverage Δ | | |---|---|---| | [src/dbus\_fast/\_\_version\_\_.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9fX3ZlcnNpb25fXy5weQ==) | `0.00% <0.00%> (ø)` | | | [src/dbus\_fast/service.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9zZXJ2aWNlLnB5) | `87.97% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/248/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.