Bluetooth-Devices / dbus-fast

A faster version of dbus-next
MIT License
35 stars 8 forks source link

feat: speed up unmarshalling Variants #254

Closed bdraco closed 11 months ago

bdraco commented 11 months ago

This is a 3.5% speed up, but we can apply the same idea in a few more places

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.46% :warning:

Comparison is base (f9b61b8) 83.29% compared to head (5a48d02) 82.83%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ========================================== - Coverage 83.29% 82.83% -0.46% ========================================== Files 28 28 Lines 3269 3275 +6 Branches 678 678 ========================================== - Hits 2723 2713 -10 - Misses 330 338 +8 - Partials 216 224 +8 ``` | [Files Changed](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices) | Coverage Δ | | |---|---|---| | [src/dbus\_fast/\_\_version\_\_.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9fX3ZlcnNpb25fXy5weQ==) | `0.00% <0.00%> (ø)` | | | [src/dbus\_fast/\_private/unmarshaller.py](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2RidXNfZmFzdC9fcHJpdmF0ZS91bm1hcnNoYWxsZXIucHk=) | `89.62% <35.29%> (-5.36%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/Bluetooth-Devices/dbus-fast/pull/254/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 11 months ago

production testing looks good