search

Bluetooth-Devices / govee-ble

Manage Govee BLE devices
Apache License 2.0
19 stars 10 forks source link

feat: add low temperature alarm to h5198 #61

Closed Ernst79 closed 1 year ago

Ernst79 commented 1 year ago

H5198 also sends a low temperature alarm for each probe

codecov[bot] commented 1 year ago

Codecov Report

Base: 87.04% // Head: 90.19% // Increases project coverage by +3.14% :tada:

Coverage data is based on head (eb6661d) compared to base (b4b2f82). Patch coverage: 84.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== + Coverage 87.04% 90.19% +3.14% ========================================== Files 2 2 Lines 193 204 +11 Branches 34 38 +4 ========================================== + Hits 168 184 +16 + Misses 18 13 -5 Partials 7 7 ``` | [Impacted Files](https://codecov.io/gh/Bluetooth-Devices/govee-ble/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/govee\_ble/parser.py](https://codecov.io/gh/Bluetooth-Devices/govee-ble/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2dvdmVlX2JsZS9wYXJzZXIucHk=) | `89.94% <83.33%> (+3.24%)` | :arrow_up: | | [src/govee\_ble/\_\_init\_\_.py](https://codecov.io/gh/Bluetooth-Devices/govee-ble/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2dvdmVlX2JsZS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ernst79 commented 1 year ago

Please, do not merge this PR yet, the user who has this device now reports that the low temperature sensor isn’t working as expected for probe 4. We'll further investigate this first.

Ernst79 commented 1 year ago

Nevermind, was an error I made in the code of BLE monitor. I’ll merge it when I have time to update the HA integration.