Bluetooth-Devices / govee-ble

Manage Govee BLE devices
Apache License 2.0
19 stars 10 forks source link

feat: add support for govee h5055 #66

Closed rcleere closed 1 year ago

rcleere commented 1 year ago

Implements and closes https://github.com/Bluetooth-Devices/govee-ble/issues/46

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 88.00% and project coverage change: +0.11% :tada:

Comparison is base (9147504) 90.19% compared to head (37d1673) 90.30%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== + Coverage 90.19% 90.30% +0.11% ========================================== Files 2 2 Lines 204 227 +23 Branches 37 44 +7 ========================================== + Hits 184 205 +21 Misses 13 13 - Partials 7 9 +2 ``` | [Files Changed](https://app.codecov.io/gh/Bluetooth-Devices/govee-ble/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices) | Coverage Δ | | |---|---|---| | [src/govee\_ble/parser.py](https://app.codecov.io/gh/Bluetooth-Devices/govee-ble/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2dvdmVlX2JsZS9wYXJzZXIucHk=) | `90.09% <87.50%> (+0.14%)` | :arrow_up: | | [src/govee\_ble/\_\_init\_\_.py](https://app.codecov.io/gh/Bluetooth-Devices/govee-ble/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bluetooth-Devices#diff-c3JjL2dvdmVlX2JsZS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bdraco commented 1 year ago

Looks good. One small review comment and should be good to merge

Thanks @rcleere