Bluewave2 / legacy-4.3.8-qBittorrent

Bring back the look of qBittorrent 4.3.X in the new 4.6.X as a theme!
67 stars 2 forks source link

Torrent and file spacing wrong? #6

Closed SatoshiHP closed 7 months ago

SatoshiHP commented 10 months ago

The spacing per torrent, and per file on the Content tab, is too close together. It was not this close in 4.3.9. Or maybe it's the font. I'm using it on 4.6.2

Is this a difference between 4.3.8 and 4.3.9?

I already switched back to 4.3.9. If this is indeed the difference between 4.3.8 and 4.3.9, I'll stay on 4.3.9. Let me know.

SatoshiHP commented 10 months ago

Also the icon to when you right click a file to 'open' is different in 4.3.9. But maybe that too is different than 4.3.8.

Bluewave2 commented 10 months ago

The spacing per torrent, and per file on the Content tab, is too close together. It was not this close in 4.3.9. Or maybe it's the font. I'm using it on 4.6.2

Is this a difference between 4.3.8 and 4.3.9?

I already switched back to 4.3.9. If this is indeed the difference between 4.3.8 and 4.3.9, I'll stay on 4.3.9. Let me know.

Hey, thanks for contributing, You're right it is, It annoyed me in the beginning too , the content tab uses a universal value for spacing in newer versions, it was separate in older versions so that's why it's off, I had to choose between the transfer list, tab selectors etc. looking correct vs the content tab, It's not too bad but not what it was.

Also the icon to when you right click a file to 'open' is different in 4.3.9. But maybe that too is different than 4.3.8.

4.3.8 image

4.6 (theme) image

there are minor differences that I thought were better than using the same generic icon for everything (i.e. force recheck icon) but maybe this is a 4.3.9 thing, i didn't use 4.3.9 so I'm not sure

Bluewave2 commented 10 months ago

Also the icon to when you right click a file to 'open' is different in 4.3.9. But maybe that too is different than 4.3.8.

oh no, I wasn't thinking, you meant the content tab, sorry, don't use it much myself

4.3.8 image

4.6 (theme) image

You're right! I missed one, thank you, I don't have the time to fix it right now but I'll make sure I get it when I do.

Bluewave2 commented 7 months ago

Icon issue fixed in https://github.com/Bluewave2/legacy-4.3.8-qBittorrent/releases/tag/v1.19