search

BoHBranch / BoH-Bay

GNU Affero General Public License v3.0
10 stars 72 forks source link

Clothing Updates #1727

Closed AMcilraith closed 2 years ago

AMcilraith commented 2 years ago

About The Pull Request

Updates fleet clothing to be fleet only, removes NTEF/SC clothes

Why It's Good For The Game

More consistency in loadout menu

Did You Test It?

Not yet, NO.

Authorship

Dr. Farson

Changelog

:cl: AMcIlraith tweak: updates uniforms to be fleet /:cl:

anconfuzedrock commented 2 years ago

If this is removing the SC uniforms (which would be extremely cringe) You're going to have to add unathi sprites for all the other fleet uniforms. they're missing as of now, and it'll go from a big issue to a BEEEEG issue if you do this.

BurpleBineapple commented 2 years ago

And, as Rock also said, if you remove the EC uniforms, you will have to sprite replacements for Unathi in all Fleet uniforms. There are no existing unathi sprites currently and this will cause sprite issues.

AMcilraith commented 2 years ago

And, as Rock also said, if you remove the EC uniforms, you will have to sprite replacements for Unathi in all Fleet uniforms. There are no existing unathi sprites currently and this will cause sprite issues.

Aye, will do so.

anconfuzedrock commented 2 years ago

It'd be cool see an actual reason for removing the SC uniforms instead of it being brushed aside like a side-effect of the PR. A lot of people actually use them.

BurpleBineapple commented 2 years ago

Listing as do not merge until sprites are added.

Anton-Kr commented 2 years ago

Honestly pretty iffy on removing EC sprites. I get the want for consistency, but that kind of went out of the window with the amount of uniform variations we have currently. I'll see how other maintainers feel about this.