Omni filters behave erratically when reconfigured

[martinlyra]

Description of issue

The Omni Gas Filter behaves erratically when you change the settings involving input and outputs. Causing following behaviour:

• Filter doesn't work even though connected to non-null pipenets each containing non-null gas mixtures. Even if turned on.
• Filter doesn't respect filter settings, and dumps everything at output from input. (E.g. a pipe that is supposed to take O2 from the filter, and the filter is set to filter O2 to that pipenet, but instead dumps the O2 along with other gases to output)

Difference between expected and actual behavior

Omni Gas Filter is supposed to respect filter settings

• O2 is filtered to the pipe that takes O2. The "waste" that didn't pass the filter is filtered away to output.
• Filter doing its job when turned on.

Steps to reproduce

1. ) Make sure that the filter is connected to two or three different pipenets.
2. ) Change the settings by changing filter destinations, Input, and Output positions.
3. ) Turn on
4. ) Observe
5. ) Use an gas analyser to easily check composition of pipenets.

If the filter is connected in a way to filter a specific gas back into the same pipenet as the input, and if the composition doesn't change despite pressure and temperature stay the same, then it is bugged.

Specific information for locating

A example location are the hot (green) and the cold (cyan) loops inside the engine room of Dagon.

Length of time in which bug has been known to occur

Unknown.

Client version, Server revision & Game ID

Client Version: 512 Server Revision: 1f6c38261effed02fee70e34425e318073fc7a88 - dev - 2020-02-09 Game ID: b5C-cSf3 Current map: NTSS Dagon

Issue bingo

• [ ] Issue could be reproduced at least once
• [x] Issue could be reproduced by different players
• [ ] Issue could be reproduced in multiple rounds
• [x] Issue happened in a recent (less than 7 days ago) round
• [x] Couldn't find an existing issue about this

[Takykardi]

If I recall correctly, omni filters also bugged out a lot on Polaris. I'll have a dig through their code later to see how they fixed it so we don't wind up with another loss of core cooling just because the filters decided they didn't like their job.