BoHBranch / BoH-Bay

GNU Affero General Public License v3.0
10 stars 70 forks source link

Non-Hooman Prosthesis #902

Open Afya212 opened 4 years ago

Afya212 commented 4 years ago

Description of issue

With certain non-human species you are unable to set limbs to be prosthesis.

Difference between expected and actual behavior

Should be able to give prosthetic limbs to your character, not able to.

Steps to reproduce

Select race on character setup (exe Tajaran), adjust limbs, click limb, click prosthesis, be sad as it doesn't work.

Specific information for locating

Length of time in which bug has been known to occur

Client version, Server revision & Game ID

Client Version: 513 Server Revision: 78206adc53f7e4ec688c44737fef6e43e0908b49 - - 2020-05-21 Game ID: b7h-a0BL

Issue bingo

Roland410 commented 4 years ago

This is probably intended, and you should clarify where and when this happens. A lot of races including I think Unathi, prometheans, etc. can't have prosthetics, robotic organs, be FBPs and some (prometheans and I think GAS as well, for example) can't even have laces.

BurgerLUA commented 4 years ago

Need to know if this is actually a bug or a feature because I am being told that this is possibily a feature.

Afya212 commented 4 years ago

I mean there shouldn't be a reason why Taj and Unathi can't have prosthetics from round start, considering. Especially considering you can get them mid round during surgery.

Roland410 commented 4 years ago

At least we're getting closer to some actual information. Unathi: https://github.com/BoHBranch/BoH-Bay/blob/35c7af86521e1548a98420adc699edc5728e2696/code/modules/species/station/lizard.dm#L51 Can't be FBP, can't have robotic internal organs, but can have prosthetic limbs.

Tajaran: https://github.com/BoHBranch/BoH-Bay/blob/e8d9a775fb204d95bb7de702253a0f1bf3f33eb2/modular_mithra/code/modules/species/station/tajaran.dm#L24 Should be able to have full prosthetics including internal organs and FBP.

If you can bring up actual examples where this happens and describe it fully how to reproduce it, then it can probably be fixed, but without such, don't expect much.

Afya212 commented 4 years ago

Already mentioned how to reproduce it. Select Taj Species, Select Adjust Limbs, Select any option, select prosthetic, then nothing happens, no menu to select brand or anything.

anconfuzedrock commented 2 years ago

For unathi it's definitely intended, they're biologically incapable of receiving augments and prosthetic organs (barely able to handle limbs). I don't know anything about taj though.

Rafflesia7793 commented 2 years ago

The issue is with the allowed bodytypes for the limbs. Despite being able to regrow limbs, Unathi can have robolimbs. However, while it does make sense for Tajarans, they cannot.

https://github.com/BoHBranch/BoH-Bay/blob/b95cdc2790810c43329ef9c3b62ab53dd4382cde/code/modules/organs/robolimbs.dm#L27

Rafflesia7793 commented 2 years ago

Issue should be corrected.

anconfuzedrock commented 2 years ago

NEW FUCKIN' PROBLEM, UNATHI WERE SUPPOSED TO BE ABLE TO HAVE ROBO LIMBS. wait a second SAID that before.

Rafflesia7793 commented 2 years ago

https://github.com/BoHBranch/BoH-Bay/pull/1453

Issue was corrected.