search

BoShurik / telegram-bot-example

BoShurikTelegramBotBundle usage example
MIT License
17 stars 13 forks source link

Use Symfony LTS 4.4 #2

Closed cybernet closed 4 years ago

cybernet commented 4 years ago

https://symfony.com/releases/4.4

End of bug fixes: November 2022

BoShurik commented 4 years ago

Thanks for contribution You forgot to change lock-file, as it's a project, not a library. Also, I prefer latest (5.0.0) version of symfony

cybernet commented 4 years ago

LTS is better, in my opinion

BoShurik commented 4 years ago

Why? It's just an example, and is better to keep it up to date. People will refer to it when they want to create new project and it likely be symfony 5

cybernet commented 4 years ago

3.4 is still being used because it's LTS, even some use 2.8 for the same reason

cybernet commented 4 years ago

Thanks for contribution You forgot to change lock-file, as it's a project, not a library. Also, I prefer latest (5.0.0) version of symfony

Then you should also use EventSubscriberInterface instead of Event :)

BoShurik commented 4 years ago

Then you should also use EventSubscriberInterface instead of Event :)

Do you mean changed signature of EventSubscriberInterface? Yes, it's not just update version constraints. It would be great to fix all deprecations in 4.4

BoShurik commented 4 years ago

Updates to 5.1 in 4a7a61d