search

BoTreeConsultingTeam / invoiceme

Invoice management
0 stars 0 forks source link

role enum based #20

Closed PragatiDoshi-BTC closed 9 years ago

PragatiDoshi-BTC commented 9 years ago

enum based roles

amitpatelx commented 9 years ago

@PragatiDoshi-BTC added few comments.

Additionally

  1. extract common form code to partial.
  2. In each edit/new form there are hardcoded path. Use routes helper methods
  3. Rails convetion for form is not followed. Check example http://guides.rubyonrails.org/layouts_and_rendering.html#partial-layouts of sample new/edit/form